Skip to content

mingw-w64-v8: add v8_enable_sandbox=false to build flags#37

Merged
jeroen merged 5 commits intomasterfrom
copilot/add-v8-enable-sandbox-flag
Apr 11, 2026
Merged

mingw-w64-v8: add v8_enable_sandbox=false to build flags#37
jeroen merged 5 commits intomasterfrom
copilot/add-v8-enable-sandbox-flag

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 11, 2026 •
edited
Loading

  • Add v8_enable_sandbox=false to the GN build flags in mingw-w64-v8/PKGBUILD
  • Fix linker error undefined reference to v8::base::SysInfo::NumberOfProcessors() by restoring --start-group/--end-group around the RSP file in the MinGW toolchain patch

Copilot AI requested a review from jeroen April 11, 2026 08:03
@jeroen
Copy link
Copy Markdown
Contributor

jeroen commented Apr 11, 2026

@copilot can you inspect the CI results and resolve the error?

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 11, 2026

@copilot can you inspect the CI results and resolve the error?

The CI was failing with undefined reference to v8::base::SysInfo::NumberOfProcessors() when linking mksnapshot.exe.

The root cause: with v8_enable_sandbox=false, the library ordering in the linker RSP file changes so that libv8_libbase.a (which defines SysInfo::NumberOfProcessors()) ends up positioned before libv8_libplatform.a in the link command. Since the MinGW toolchain patch had removed --start-group/--end-group wrapping from the RSP file, the linker couldn't re-scan libv8_libbase.a to resolve the symbol needed by libv8_libplatform.a.

Fixed in ba707f5 by restoring -Wl,--start-group @"$rspfile" -Wl,--end-group in the MinGW toolchain patch's executable link command, allowing the linker to make multiple passes over the static archives.

@jeroen jeroen force-pushed the copilot/add-v8-enable-sandbox-flag branch from d746350 to f80baf6 Compare April 11, 2026 10:41
@jeroen jeroen marked this pull request as ready for review April 11, 2026 13:00
@jeroen jeroen merged commit 5da138f into master Apr 11, 2026
0 of 6 checks passed
@jeroen jeroen deleted the copilot/add-v8-enable-sandbox-flag branch April 11, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeroen jeroen Awaiting requested review from jeroen

Assignees

@jeroen jeroen

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jeroen